Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d979f74 authored by Ron Mercer's avatar Ron Mercer Committed by David S. Miller
Browse files

qlge: bugfix: Fix TSO breakage. 



Moved the buffer mapping to a point after TSO logic has modified the
iph->check field. We were seeing stale data on the PCIe bus.

Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 06a3d510

drivers/net/qlge/qlge_main.c

+6 −4
Original line number Diff line number Diff line
@@ -1936,10 +1936,6 @@ static int qlge_send(struct sk_buff *skb, struct net_device *ndev) 
	tx_ring_desc = &tx_ring->q[tx_ring->prod_idx];

	mac_iocb_ptr = tx_ring_desc->queue_entry;

	memset((void *)mac_iocb_ptr, 0, sizeof(mac_iocb_ptr));

	if (ql_map_send(qdev, mac_iocb_ptr, skb, tx_ring_desc) != NETDEV_TX_OK) {

		QPRINTK(qdev, TX_QUEUED, ERR, "Could not map the segments.\n");

		return NETDEV_TX_BUSY;

	}



	mac_iocb_ptr->opcode = OPCODE_OB_MAC_IOCB;

	mac_iocb_ptr->tid = tx_ring_desc->index;
@@ -1965,6 +1961,12 @@ static int qlge_send(struct sk_buff *skb, struct net_device *ndev) 
		ql_hw_csum_setup(skb,

				 (struct ob_mac_tso_iocb_req *)mac_iocb_ptr);

	}

	if (ql_map_send(qdev, mac_iocb_ptr, skb, tx_ring_desc) !=

			NETDEV_TX_OK) {

		QPRINTK(qdev, TX_QUEUED, ERR,

				"Could not map the segments.\n");

		return NETDEV_TX_BUSY;

	}

	QL_DUMP_OB_MAC_IOCB(mac_iocb_ptr);

	tx_ring->prod_idx++;

	if (tx_ring->prod_idx == tx_ring->wq_len)