Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d769a52 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

sound: sound_firmware: Fix invalid use of vfs_read() 



It should use kernel_read() instead of vfs_read() to load a firmware
binary onto the kernel pages.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 574d69c2

sound/sound_firmware.c

+1 −3
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ static int do_mod_firmware_load(const char *fn, char **fp) 
	struct file* filp;

	long l;

	char *dp;

	loff_t pos;



	filp = filp_open(fn, 0, 0);

	if (IS_ERR(filp))
@@ -34,8 +33,7 @@ static int do_mod_firmware_load(const char *fn, char **fp) 
		fput(filp);

		return 0;

	}

	pos = 0;

	if (vfs_read(filp, dp, l, &pos) != l)

	if (kernel_read(filp, 0, dp, l) != l)

	{

		printk(KERN_INFO "Failed to read '%s'.\n", fn);

		vfree(dp);