Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c00f71e authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

appletalk: Fix compile regression 



[ Upstream commit 27da0d2ef998e222a876c0cec72aa7829a626266 ]

A bugfix just broke compilation of appletalk when CONFIG_SYSCTL
is disabled:

In file included from net/appletalk/ddp.c:65:
net/appletalk/ddp.c: In function 'atalk_init':
include/linux/atalk.h:164:34: error: expected expression before 'do'
 #define atalk_register_sysctl()  do { } while(0)
                                  ^~
net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl'
  rc = atalk_register_sysctl();

This is easier to avoid by using conventional inline functions
as stubs rather than macros. The header already has inline
functions for other purposes, so I'm changing over all the
macros for consistency.

Fixes: 6377f787aeb9 ("appletalk: Fix use-after-free in atalk_proc_exit")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9e91db59

include/linux/atalk.h

+14 −4
Original line number Diff line number Diff line
@@ -161,16 +161,26 @@ extern int sysctl_aarp_resolve_time; 
extern int atalk_register_sysctl(void);

extern void atalk_unregister_sysctl(void);

#else

#define atalk_register_sysctl()		do { } while(0)

#define atalk_unregister_sysctl()	do { } while(0)

static inline int atalk_register_sysctl(void)

{

	return 0;

}

static inline void atalk_unregister_sysctl(void)

{

}

#endif



#ifdef CONFIG_PROC_FS

extern int atalk_proc_init(void);

extern void atalk_proc_exit(void);

#else

#define atalk_proc_init()	({ 0; })

#define atalk_proc_exit()	do { } while(0)

static inline int atalk_proc_init(void)

{

	return 0;

}

static inline void atalk_proc_exit(void)

{

}

#endif /* CONFIG_PROC_FS */



#endif /* __LINUX_ATALK_H__ */