Commit 0a6b2a1d authored Feb 19, 2018 by Eric Dumazet Committed by David S. Miller Feb 21, 2018

tcp: switch to GSO being always on



Oleksandr Natalenko reported performance issues with BBR without FQ
packet scheduler that were root caused to lack of SG and GSO/TSO on
his configuration.

In this mode, TCP internal pacing has to setup a high resolution timer
for each MSS sent.

We could implement in TCP a strategy similar to the one adopted
in commit fefa569a ("net_sched: sch_fq: account for schedule/timers drifts")
or decide to finally switch TCP stack to a GSO only mode.

This has many benefits :

1) Most TCP developments are done with TSO in mind.
2) Less high-resolution timers needs to be armed for TCP-pacing
3) GSO can benefit of xmit_more hint
4) Receiver GRO is more effective (as if TSO was used for real on sender)
   -> Lower ACK traffic
5) Write queues have less overhead (one skb holds about 64KB of payload)
6) SACK coalescing just works.
7) rtx rb-tree contains less packets, SACK is cheaper.

This patch implements the minimum patch, but we can remove some legacy
code as follow ups.

Tested:

On 40Gbit link, one netperf -t TCP_STREAM

BBR+fq:
sg on:  26 Gbits/sec
sg off: 15.7 Gbits/sec   (was 2.3 Gbit before patch)

BBR+pfifo_fast:
sg on:  24.2 Gbits/sec
sg off: 14.9 Gbits/sec  (was 0.66 Gbit before patch !!! )

BBR+fq_codel:
sg on:  24.4 Gbits/sec
sg off: 15 Gbits/sec  (was 0.66 Gbit before patch !!! )

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 960103ff

include/net/sock.h

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -417,6 +417,7 @@ struct sock {
	struct page_frag sk_frag;		struct page_frag sk_frag;
	netdev_features_t sk_route_caps;		netdev_features_t sk_route_caps;
	netdev_features_t sk_route_nocaps;		netdev_features_t sk_route_nocaps;
			netdev_features_t sk_route_forced_caps;
	int sk_gso_type;		int sk_gso_type;
	unsigned int sk_gso_max_size;		unsigned int sk_gso_max_size;
	gfp_t sk_allocation;		gfp_t sk_allocation;

net/core/sock.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1777,7 +1777,7 @@ void sk_setup_caps(struct sock sk, struct dst_entry dst)
	u32 max_segs = 1;		u32 max_segs = 1;

	sk_dst_set(sk, dst);		sk_dst_set(sk, dst);
	sk->sk_route_caps = dst->dev->features;		sk->sk_route_caps = dst->dev->features \| sk->sk_route_forced_caps;
	if (sk->sk_route_caps & NETIF_F_GSO)		if (sk->sk_route_caps & NETIF_F_GSO)
	sk->sk_route_caps \|= NETIF_F_GSO_SOFTWARE;		sk->sk_route_caps \|= NETIF_F_GSO_SOFTWARE;
	sk->sk_route_caps &= ~sk->sk_route_nocaps;		sk->sk_route_caps &= ~sk->sk_route_nocaps;

net/ipv4/tcp.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -453,6 +453,7 @@ void tcp_init_sock(struct sock *sk)
	sk->sk_rcvbuf = sock_net(sk)->ipv4.sysctl_tcp_rmem[1];		sk->sk_rcvbuf = sock_net(sk)->ipv4.sysctl_tcp_rmem[1];

	sk_sockets_allocated_inc(sk);		sk_sockets_allocated_inc(sk);
			sk->sk_route_forced_caps = NETIF_F_GSO;
	}		}
	EXPORT_SYMBOL(tcp_init_sock);		EXPORT_SYMBOL(tcp_init_sock);