Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09acfea5 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Fix a few sparse warnings 



net/sunrpc/svcsock.c:412:22: warning: incorrect type in assignment
(different address spaces)
 - svc_partial_recvfrom now takes a struct kvec, so the variable
   save_iovbase needs to be an ordinary (void *)

Make a bunch of variables in net/sunrpc/xprtsock.c static

Fix a couple of "warning: symbol 'foo' was not declared. Should it be
static?" reports.

Fix a couple of conflicting function declarations.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 17280175

include/linux/sunrpc/bc_xprt.h

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
struct rpc_rqst *xprt_alloc_bc_request(struct rpc_xprt *xprt);

void xprt_free_bc_request(struct rpc_rqst *req);

int xprt_setup_backchannel(struct rpc_xprt *, unsigned int min_reqs);

void xprt_destroy_backchannel(struct rpc_xprt *, int max_reqs);

void xprt_destroy_backchannel(struct rpc_xprt *, unsigned int max_reqs);

int bc_send(struct rpc_rqst *req);



/*

include/linux/sunrpc/svcauth.h

+3 −0
Original line number Diff line number Diff line
@@ -135,6 +135,9 @@ extern void svcauth_unix_purge(void); 
extern void svcauth_unix_info_release(struct svc_xprt *xpt);

extern int svcauth_unix_set_client(struct svc_rqst *rqstp);



extern int unix_gid_cache_create(struct net *net);

extern void unix_gid_cache_destroy(struct net *net);



static inline unsigned long hash_str(char *name, int bits)

{

	unsigned long hash = 0;

include/linux/sunrpc/xprtsock.h

+0 −12
Original line number Diff line number Diff line
@@ -12,18 +12,6 @@ 
int		init_socket_xprt(void);

void		cleanup_socket_xprt(void);



/*

 * RPC slot table sizes for UDP, TCP transports

 */

extern unsigned int xprt_udp_slot_table_entries;

extern unsigned int xprt_tcp_slot_table_entries;



/*

 * Parameters for choosing a free port

 */

extern unsigned int xprt_min_resvport;

extern unsigned int xprt_max_resvport;



#define RPC_MIN_RESVPORT	(1U)

#define RPC_MAX_RESVPORT	(65535U)

#define RPC_DEF_MIN_RESVPORT	(665U)

net/sunrpc/auth_gss/gss_krb5_mech.c

+1 −1
Original line number Diff line number Diff line
@@ -344,7 +344,7 @@ gss_import_v1_context(const void *p, const void *end, struct krb5_ctx *ctx) 
	return PTR_ERR(p);

}



struct crypto_blkcipher *

static struct crypto_blkcipher *

context_v2_alloc_cipher(struct krb5_ctx *ctx, const char *cname, u8 *key)

{

	struct crypto_blkcipher *cp;

net/sunrpc/auth_gss/gss_krb5_seal.c

+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ gss_get_mic_v1(struct krb5_ctx *ctx, struct xdr_buf *text, 
	return (ctx->endtime < now) ? GSS_S_CONTEXT_EXPIRED : GSS_S_COMPLETE;

}



u32

static u32

gss_get_mic_v2(struct krb5_ctx *ctx, struct xdr_buf *text,

		struct xdr_netobj *token)

{