Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 093019cf authored by Xi Wang's avatar Xi Wang Committed by Ben Myers
Browse files

xfs: fix acl count validation in xfs_acl_from_disk() 



Commit fa8b18ed didn't prevent the integer overflow and possible
memory corruption.  "count" can go negative and bypass the check.

Signed-off-by: default avatarXi Wang <xi.wang@gmail.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent 687d1c5e

fs/xfs/xfs_acl.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp) 
	struct posix_acl_entry *acl_e;

	struct posix_acl *acl;

	struct xfs_acl_entry *ace;

	int count, i;

	unsigned int count, i;



	count = be32_to_cpu(aclp->acl_cnt);

	if (count > XFS_ACL_MAX_ENTRIES)