Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07b76ba9 authored by Volodymyr Bendiuga's avatar Volodymyr Bendiuga Committed by David S. Miller
Browse files

dsa:mv88e6xxx: allow address 0x1 in smi_init 



Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.

Signed-off-by: default avatarVolodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 28fa4f30

drivers/net/dsa/mv88e6xxx/chip.c

+0 −4
Original line number Diff line number Diff line
@@ -4240,10 +4240,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip) 
static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,

			      struct mii_bus *bus, int sw_addr)

{

	/* ADDR[0] pin is unavailable externally and considered zero */

	if (sw_addr & 0x1)

		return -EINVAL;



	if (sw_addr == 0)

		chip->smi_ops = &mv88e6xxx_smi_single_chip_ops;

	else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))