Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06da5325 authored by Hans de Goede's avatar Hans de Goede Committed by Darren Hart
Browse files

platform/x86: thinkpad_acpi: Stop setting led_classdev brightness directly 



There is no need to set the led_classdev's brightness value from
its set_brightness callback, this is taken care of by the led-core and
thinkpad_acpi really should not be mucking with it.

Note that kbdlight_set_level_and_update() is still used by the old
thinpad_acpi specific sysfs interface for the led, so we cannot
remove it.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
parent b8c5099b

drivers/platform/x86/thinkpad_acpi.c

+1 −3
Original line number Diff line number Diff line
@@ -5095,8 +5095,6 @@ static int kbdlight_set_level(int level) 
	return 0;

}



static int kbdlight_set_level_and_update(int level);



static int kbdlight_get_level(void)

{

	int status = 0;
@@ -5164,7 +5162,7 @@ static void kbdlight_set_worker(struct work_struct *work) 
			container_of(work, struct tpacpi_led_classdev, work);



	if (likely(tpacpi_lifecycle == TPACPI_LIFE_RUNNING))

		kbdlight_set_level_and_update(data->new_state);

		kbdlight_set_level(data->new_state);

}



static void kbdlight_sysfs_set(struct led_classdev *led_cdev,