Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 052ad019 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jack Pham
Browse files

aio: remove an outdated BUG_ON and comment in aio_complete



These days we don't treat sync iocbs special in the aio completion code as
they never use it.  Remove the old comment and BUG_ON given that the
current definition of is_sync_kiocb makes it impossible to hit.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Change-Id: I67331a81f721c12072f51cd7d3e8bd1ce3f56966
Git-commit: c213dc82
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarJack Pham <jackp@codeaurora.org>
parent ff5a3abb
Loading
Loading
Loading
Loading
+0 −9
Original line number Diff line number Diff line
@@ -1120,15 +1120,6 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2)
		file_end_write(file);
	}

	/*
	 * Special case handling for sync iocbs:
	 *  - events go directly into the iocb for fast handling
	 *  - the sync task with the iocb in its stack holds the single iocb
	 *    ref, no other paths have a way to get another ref
	 *  - the sync task helpfully left a reference to itself in the iocb
	 */
	BUG_ON(is_sync_kiocb(kiocb));

	if (iocb->ki_list.next) {
		unsigned long flags;