Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 049d7fb7 authored by Coly Li's avatar Coly Li Committed by Greg Kroah-Hartman
Browse files

bcache: add code comments for bch_btree_node_get() and __bch_btree_node_alloc() 



[ Upstream commit 31f5b956a197d4ec25c8a07cb3a2ab69d0c0b82f ]

This patch adds code comments to bch_btree_node_get() and
__bch_btree_node_alloc() that NULL pointer will not be returned and it
is unnecessary to check NULL pointer by the callers of these routines.

Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20231120052503.6122-10-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a0231628

drivers/md/bcache/btree.c

+7 −0
Original line number Diff line number Diff line
@@ -972,6 +972,9 @@ static struct btree *mca_alloc(struct cache_set *c, struct btree_op *op, 
 *

 * The btree node will have either a read or a write lock held, depending on

 * level and op->lock.

 *

 * Note: Only error code or btree pointer will be returned, it is unncessary

 *       for callers to check NULL pointer.

 */

struct btree *bch_btree_node_get(struct cache_set *c, struct btree_op *op,

				 struct bkey *k, int level, bool write,
@@ -1070,6 +1073,10 @@ static void btree_node_free(struct btree *b) 
	mutex_unlock(&b->c->bucket_lock);

}



/*

 * Only error code or btree pointer will be returned, it is unncessary for

 * callers to check NULL pointer.

 */

struct btree *__bch_btree_node_alloc(struct cache_set *c, struct btree_op *op,

				     int level, bool wait,

				     struct btree *parent)