Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04698ccc authored by John Crispin's avatar John Crispin Committed by David S. Miller
Browse files

net: mediatek: fix threshold value 



The logic to calculate the threshold value for stopping the TX queue is
bad. Currently it will always use 1/2 of the rings size, which is way too
much. Set the threshold to MAX_SKB_FRAGS. This makes sure that the queue
is stopped when there is not enough room to accept an additional segment. 

Signed-off-by: default avatarJohn Crispin <john@phrozen.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2ff0bb61

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+1 −2
Original line number Diff line number Diff line
@@ -1033,8 +1033,7 @@ static int mtk_tx_alloc(struct mtk_eth *eth) 
	atomic_set(&ring->free_count, MTK_DMA_SIZE - 2);

	ring->next_free = &ring->dma[0];

	ring->last_free = &ring->dma[MTK_DMA_SIZE - 2];

	ring->thresh = max((unsigned long)MTK_DMA_SIZE >> 2,

			      MAX_SKB_FRAGS);

	ring->thresh = MAX_SKB_FRAGS;



	/* make sure that all changes to the dma ring are flushed before we

	 * continue