Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0164a711 authored by James Hogan's avatar James Hogan
Browse files

metag: Fix ioremap_wc/ioremap_cached build errors 



When ioremap_wc() or ioremap_cached() are used without first including
asm/pgtable.h, the _PAGE_CACHEABLE or _PAGE_WR_COMBINE definitions
aren't found, resulting in build errors like the following (in
next-20150323 due to "lib: devres: add a helper function for
ioremap_wc"):

lib/devres.c: In function ‘devm_ioremap_wc’:
lib/devres.c:91: error: ‘_PAGE_WR_COMBINE’ undeclared

We can't easily include asm/pgtable.h in asm/io.h due to dependency
problems, so split out the _PAGE_* definitions from asm/pgtable.h into a
separate asm/pgtable-bits.h header (as a couple of other architectures
already do), and include that in io.h instead.

Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Cc: linux-metag@vger.kernel.org
Cc: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9eccca08

arch/metag/include/asm/io.h

+1 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
#define _ASM_METAG_IO_H



#include <linux/types.h>

#include <asm/pgtable-bits.h>



#define IO_SPACE_LIMIT  0

arch/metag/include/asm/pgtable-bits.h

0 → 100644
+104 −0
Original line number Diff line number Diff line 
/*

 * Meta page table definitions.

 */



#ifndef _METAG_PGTABLE_BITS_H

#define _METAG_PGTABLE_BITS_H



#include <asm/metag_mem.h>



/*

 * Definitions for MMU descriptors

 *

 * These are the hardware bits in the MMCU pte entries.

 * Derived from the Meta toolkit headers.

 */

#define _PAGE_PRESENT		MMCU_ENTRY_VAL_BIT

#define _PAGE_WRITE		MMCU_ENTRY_WR_BIT

#define _PAGE_PRIV		MMCU_ENTRY_PRIV_BIT

/* Write combine bit - this can cause writes to occur out of order */

#define _PAGE_WR_COMBINE	MMCU_ENTRY_WRC_BIT

/* Sys coherent bit - this bit is never used by Linux */

#define _PAGE_SYS_COHERENT	MMCU_ENTRY_SYS_BIT

#define _PAGE_ALWAYS_ZERO_1	0x020

#define _PAGE_CACHE_CTRL0	0x040

#define _PAGE_CACHE_CTRL1	0x080

#define _PAGE_ALWAYS_ZERO_2	0x100

#define _PAGE_ALWAYS_ZERO_3	0x200

#define _PAGE_ALWAYS_ZERO_4	0x400

#define _PAGE_ALWAYS_ZERO_5	0x800



/* These are software bits that we stuff into the gaps in the hardware

 * pte entries that are not used.  Note, these DO get stored in the actual

 * hardware, but the hardware just does not use them.

 */

#define _PAGE_ACCESSED		_PAGE_ALWAYS_ZERO_1

#define _PAGE_DIRTY		_PAGE_ALWAYS_ZERO_2



/* Pages owned, and protected by, the kernel. */

#define _PAGE_KERNEL		_PAGE_PRIV



/* No cacheing of this page */

#define _PAGE_CACHE_WIN0	(MMCU_CWIN_UNCACHED << MMCU_ENTRY_CWIN_S)

/* burst cacheing - good for data streaming */

#define _PAGE_CACHE_WIN1	(MMCU_CWIN_BURST << MMCU_ENTRY_CWIN_S)

/* One cache way per thread */

#define _PAGE_CACHE_WIN2	(MMCU_CWIN_C1SET << MMCU_ENTRY_CWIN_S)

/* Full on cacheing */

#define _PAGE_CACHE_WIN3	(MMCU_CWIN_CACHED << MMCU_ENTRY_CWIN_S)



#define _PAGE_CACHEABLE		(_PAGE_CACHE_WIN3 | _PAGE_WR_COMBINE)



/* which bits are used for cache control ... */

#define _PAGE_CACHE_MASK	(_PAGE_CACHE_CTRL0 | _PAGE_CACHE_CTRL1 | \

				 _PAGE_WR_COMBINE)



/* This is a mask of the bits that pte_modify is allowed to change. */

#define _PAGE_CHG_MASK		(PAGE_MASK)



#define _PAGE_SZ_SHIFT		1

#define _PAGE_SZ_4K		(0x0)

#define _PAGE_SZ_8K		(0x1 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_16K		(0x2 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_32K		(0x3 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_64K		(0x4 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_128K		(0x5 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_256K		(0x6 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_512K		(0x7 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_1M		(0x8 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_2M		(0x9 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_4M		(0xa << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_MASK		(0xf << _PAGE_SZ_SHIFT)



#if defined(CONFIG_PAGE_SIZE_4K)

#define _PAGE_SZ		(_PAGE_SZ_4K)

#elif defined(CONFIG_PAGE_SIZE_8K)

#define _PAGE_SZ		(_PAGE_SZ_8K)

#elif defined(CONFIG_PAGE_SIZE_16K)

#define _PAGE_SZ		(_PAGE_SZ_16K)

#endif

#define _PAGE_TABLE		(_PAGE_SZ | _PAGE_PRESENT)



#if defined(CONFIG_HUGETLB_PAGE_SIZE_8K)

# define _PAGE_SZHUGE		(_PAGE_SZ_8K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_16K)

# define _PAGE_SZHUGE		(_PAGE_SZ_16K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_32K)

# define _PAGE_SZHUGE		(_PAGE_SZ_32K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_64K)

# define _PAGE_SZHUGE		(_PAGE_SZ_64K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_128K)

# define _PAGE_SZHUGE		(_PAGE_SZ_128K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_256K)

# define _PAGE_SZHUGE		(_PAGE_SZ_256K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_512K)

# define _PAGE_SZHUGE		(_PAGE_SZ_512K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_1M)

# define _PAGE_SZHUGE		(_PAGE_SZ_1M)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_2M)

# define _PAGE_SZHUGE		(_PAGE_SZ_2M)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_4M)

# define _PAGE_SZHUGE		(_PAGE_SZ_4M)

#endif



#endif /* _METAG_PGTABLE_BITS_H */

arch/metag/include/asm/pgtable.h

+1 −94
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
#ifndef _METAG_PGTABLE_H

#define _METAG_PGTABLE_H



#include <asm/pgtable-bits.h>

#include <asm-generic/pgtable-nopmd.h>



/* Invalid regions on Meta: 0x00000000-0x001FFFFF and 0xFFFF0000-0xFFFFFFFF */
@@ -20,100 +21,6 @@ 
#define VMALLOC_END		0x7FFFFFFF

#endif



/*

 * Definitions for MMU descriptors

 *

 * These are the hardware bits in the MMCU pte entries.

 * Derived from the Meta toolkit headers.

 */

#define _PAGE_PRESENT		MMCU_ENTRY_VAL_BIT

#define _PAGE_WRITE		MMCU_ENTRY_WR_BIT

#define _PAGE_PRIV		MMCU_ENTRY_PRIV_BIT

/* Write combine bit - this can cause writes to occur out of order */

#define _PAGE_WR_COMBINE	MMCU_ENTRY_WRC_BIT

/* Sys coherent bit - this bit is never used by Linux */

#define _PAGE_SYS_COHERENT	MMCU_ENTRY_SYS_BIT

#define _PAGE_ALWAYS_ZERO_1	0x020

#define _PAGE_CACHE_CTRL0	0x040

#define _PAGE_CACHE_CTRL1	0x080

#define _PAGE_ALWAYS_ZERO_2	0x100

#define _PAGE_ALWAYS_ZERO_3	0x200

#define _PAGE_ALWAYS_ZERO_4	0x400

#define _PAGE_ALWAYS_ZERO_5	0x800



/* These are software bits that we stuff into the gaps in the hardware

 * pte entries that are not used.  Note, these DO get stored in the actual

 * hardware, but the hardware just does not use them.

 */

#define _PAGE_ACCESSED		_PAGE_ALWAYS_ZERO_1

#define _PAGE_DIRTY		_PAGE_ALWAYS_ZERO_2



/* Pages owned, and protected by, the kernel. */

#define _PAGE_KERNEL		_PAGE_PRIV



/* No cacheing of this page */

#define _PAGE_CACHE_WIN0	(MMCU_CWIN_UNCACHED << MMCU_ENTRY_CWIN_S)

/* burst cacheing - good for data streaming */

#define _PAGE_CACHE_WIN1	(MMCU_CWIN_BURST << MMCU_ENTRY_CWIN_S)

/* One cache way per thread */

#define _PAGE_CACHE_WIN2	(MMCU_CWIN_C1SET << MMCU_ENTRY_CWIN_S)

/* Full on cacheing */

#define _PAGE_CACHE_WIN3	(MMCU_CWIN_CACHED << MMCU_ENTRY_CWIN_S)



#define _PAGE_CACHEABLE		(_PAGE_CACHE_WIN3 | _PAGE_WR_COMBINE)



/* which bits are used for cache control ... */

#define _PAGE_CACHE_MASK	(_PAGE_CACHE_CTRL0 | _PAGE_CACHE_CTRL1 | \

				 _PAGE_WR_COMBINE)



/* This is a mask of the bits that pte_modify is allowed to change. */

#define _PAGE_CHG_MASK		(PAGE_MASK)



#define _PAGE_SZ_SHIFT		1

#define _PAGE_SZ_4K		(0x0)

#define _PAGE_SZ_8K		(0x1 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_16K		(0x2 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_32K		(0x3 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_64K		(0x4 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_128K		(0x5 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_256K		(0x6 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_512K		(0x7 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_1M		(0x8 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_2M		(0x9 << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_4M		(0xa << _PAGE_SZ_SHIFT)

#define _PAGE_SZ_MASK		(0xf << _PAGE_SZ_SHIFT)



#if defined(CONFIG_PAGE_SIZE_4K)

#define _PAGE_SZ		(_PAGE_SZ_4K)

#elif defined(CONFIG_PAGE_SIZE_8K)

#define _PAGE_SZ		(_PAGE_SZ_8K)

#elif defined(CONFIG_PAGE_SIZE_16K)

#define _PAGE_SZ		(_PAGE_SZ_16K)

#endif

#define _PAGE_TABLE		(_PAGE_SZ | _PAGE_PRESENT)



#if defined(CONFIG_HUGETLB_PAGE_SIZE_8K)

# define _PAGE_SZHUGE		(_PAGE_SZ_8K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_16K)

# define _PAGE_SZHUGE		(_PAGE_SZ_16K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_32K)

# define _PAGE_SZHUGE		(_PAGE_SZ_32K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_64K)

# define _PAGE_SZHUGE		(_PAGE_SZ_64K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_128K)

# define _PAGE_SZHUGE		(_PAGE_SZ_128K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_256K)

# define _PAGE_SZHUGE		(_PAGE_SZ_256K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_512K)

# define _PAGE_SZHUGE		(_PAGE_SZ_512K)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_1M)

# define _PAGE_SZHUGE		(_PAGE_SZ_1M)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_2M)

# define _PAGE_SZHUGE		(_PAGE_SZ_2M)

#elif defined(CONFIG_HUGETLB_PAGE_SIZE_4M)

# define _PAGE_SZHUGE		(_PAGE_SZ_4M)

#endif



/*

 * The Linux memory management assumes a three-level page table setup. On

 * Meta, we use that, but "fold" the mid level into the top-level page