Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff32f8ab authored by Vasundhara Volam's avatar Vasundhara Volam Committed by David S. Miller
Browse files

be2net: ignore mac-addr set call for an already programmed mac-addr 



An ndo_set_mac_addr() call may be issued for a mac-addr that is already
active on an interface. If so, silently ignore the request. Sending such
a request to the FW, causes a "mac collision" error. The error is harmless
but is avoidable noise in the kernel log.

Signed-off-by: default avatarVasundhara Volam <vasundhara.volam@emulex.com>
Signed-off-by: default avatarSathya Perla <sathya.perla@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent baaa08d1

drivers/net/ethernet/emulex/benet/be_main.c

+6 −0
Original line number Diff line number Diff line
@@ -258,6 +258,12 @@ static int be_mac_addr_set(struct net_device *netdev, void *p) 
	if (!is_valid_ether_addr(addr->sa_data))

		return -EADDRNOTAVAIL;



	/* Proceed further only if, User provided MAC is different

	 * from active MAC

	 */

	if (ether_addr_equal(addr->sa_data, netdev->dev_addr))

		return 0;



	/* The PMAC_ADD cmd may fail if the VF doesn't have FILTMGMT

	 * privilege or if PF did not provision the new MAC address.

	 * On BE3, this cmd will always fail if the VF doesn't have the