Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff1a4a7b authored by Parag Warudkar's avatar Parag Warudkar Committed by Linus Torvalds
Browse files

isight_firmware: fix a leak and double kfree() 



Signed-off-by: default avatarParag Warudkar <parag.warudkar@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 66198f36

drivers/usb/misc/isight_firmware.c

+2 −2
Original line number Diff line number Diff line
@@ -48,7 +48,8 @@ static int isight_firmware_load(struct usb_interface *intf, 


	if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {

		printk(KERN_ERR "Unable to load isight firmware\n");

		return -ENODEV;

		ret = -ENODEV;

		goto out;

	}



	ptr = firmware->data;
@@ -91,7 +92,6 @@ static int isight_firmware_load(struct usb_interface *intf, 
			     buf, llen, 300) != llen) {

				printk(KERN_ERR

				       "Failed to load isight firmware\n");

				kfree(buf);

				ret = -ENODEV;

				goto out;

			}