Commit fe9d861b authored Nov 15, 2017 by Jan Kara Committed by Jaegeuk Kim Jul 08, 2018

nilfs2: use pagevec_lookup_range_tag()

We want only pages from given range in nilfs_lookup_dirty_data_buffers().
Use pagevec_lookup_range_tag() instead of pagevec_lookup_tag() and
remove unnecessary code.

Link: http://lkml.kernel.org/r/20171009151359.31984-10-jack@suse.cz


Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4050363a

fs/nilfs2/segment.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -643,18 +643,14 @@ static size_t nilfs_lookup_dirty_data_buffers(struct inode *inode,
		pagevec_init(&pvec, 0);
		repeat:
		if (unlikely(index > last) \|\|
		!pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
		min_t(pgoff_t, last - index,
		PAGEVEC_SIZE - 1) + 1))
		!pagevec_lookup_range_tag(&pvec, mapping, &index, last,
		PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE))
		return ndirties;

		for (i = 0; i < pagevec_count(&pvec); i++) {
		struct buffer_head bh, head;
		struct page *page = pvec.pages[i];

		if (unlikely(page->index > last))
		break;

		lock_page(page);
		if (!page_has_buffers(page))
		create_empty_buffers(page, 1 << inode->i_blkbits, 0);