Commit fe979ac1 authored May 23, 2007 by Vlad Yasevich Committed by Vladislav Yasevich Jun 13, 2007

[SCTP] Fix leak in sctp_getsockopt_local_addrs when copy_to_user fails



If the copy_to_user or copy_user calls fail in sctp_getsockopt_local_addrs(),
the function should free locally allocated storage before returning error.
Spotted by Coverity.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Acked-by: Sridhar Samudrala <sri@us.ibm.com>

parent 8b358056

net/sctp/socket.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -4352,11 +4352,12 @@ copy_getaddrs:
		err = -EFAULT;
		goto error;
		}
		if (put_user(cnt, &((struct sctp_getaddrs __user *)optval)->addr_num))
		return -EFAULT;
		if (put_user(cnt, &((struct sctp_getaddrs __user *)optval)->addr_num)) {
		err = -EFAULT;
		goto error;
		}
		if (put_user(bytes_copied, optlen))
		return -EFAULT;

		err = -EFAULT;
		error:
		kfree(addrs);
		return err;