Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe3b5bfe authored by Darrick J. Wong's avatar Darrick J. Wong Committed by James Bottomley
Browse files

[SCSI] libsas: sysfs phy control attributes should not be S_IWUGO 



Allowing the phy reset controls to be world-triggerable does not seem like
a terribly good idea because SAS devices can be disrupted (and ATA devices
are really disrupted) by a phy reset.  By default only root should be able
to do things like that.

Signed-off-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 57ba07dc

drivers/scsi/scsi_transport_sas.c

+2 −2
Original line number Diff line number Diff line
@@ -1446,10 +1446,10 @@ static int sas_user_scan(struct Scsi_Host *shost, uint channel, 
	SETUP_TEMPLATE(phy_attrs, field, S_IRUGO, i->f->func)



#define SETUP_PHY_ATTRIBUTE_WRONLY(field)				\

	SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, 1)

	SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, 1)



#define SETUP_OPTIONAL_PHY_ATTRIBUTE_WRONLY(field, func)		\

	SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, i->f->func)

	SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, i->f->func)



#define SETUP_END_DEV_ATTRIBUTE(field)					\

	SETUP_TEMPLATE(end_dev_attrs, field, S_IRUGO, 1)