Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe041646 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] cx231xxx: fix typo in saddr_len check 



The original code compared "saddr_len" with zero twice in a nonsensical
way.  I asked the list, and Andy Walls and Sri Deevi say that the second
check should be if "saddr_len == 1".

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarSrinivasa Deevi <Srinivasa.deevi@conexant.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 50155c25

drivers/media/video/cx231xx/cx231xx-core.c

+4 −4
Original line number Diff line number Diff line
@@ -1515,7 +1515,7 @@ int cx231xx_read_i2c_master(struct cx231xx *dev, u8 dev_addr, u16 saddr, 


	if (saddr_len == 0)

		saddr = 0;

	else if (saddr_len == 0)

	else if (saddr_len == 1)

		saddr &= 0xff;



	/* prepare xfer_data struct */
@@ -1566,7 +1566,7 @@ int cx231xx_write_i2c_master(struct cx231xx *dev, u8 dev_addr, u16 saddr, 


	if (saddr_len == 0)

		saddr = 0;

	else if (saddr_len == 0)

	else if (saddr_len == 1)

		saddr &= 0xff;



	/* prepare xfer_data struct */
@@ -1600,7 +1600,7 @@ int cx231xx_read_i2c_data(struct cx231xx *dev, u8 dev_addr, u16 saddr, 


	if (saddr_len == 0)

		saddr = 0;

	else if (saddr_len == 0)

	else if (saddr_len == 1)

		saddr &= 0xff;



	/* prepare xfer_data struct */
@@ -1641,7 +1641,7 @@ int cx231xx_write_i2c_data(struct cx231xx *dev, u8 dev_addr, u16 saddr, 


	if (saddr_len == 0)

		saddr = 0;

	else if (saddr_len == 0)

	else if (saddr_len == 1)

		saddr &= 0xff;



	/* prepare xfer_data struct */