Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fde5217c authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

bnx2x: use the right constant 

[ Upstream commit dd612f18a49b63af8b3a5f572d999bdb197385bc ]

Nearby code that also tests port suggests that the P0 constant should be
used when port is zero.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e,e1;
@@

* e ? e1 : e1
// </smpl>

Fixes: 6c3218c6 ("bnx2x: Adjust ETS to 578xx")
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a168225

drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c

+1 −1
Original line number Diff line number Diff line
@@ -588,7 +588,7 @@ static void bnx2x_ets_e3b0_nig_disabled(const struct link_params *params, 
	 * slots for the highest priority.

	 */

	REG_WR(bp, (port) ? NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS :

		   NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100);

		   NIG_REG_P0_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100);

	/* Mapping between the CREDIT_WEIGHT registers and actual client

	 * numbers

	 */