Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fddaaae1 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Adrian Bunk
Browse files

BUG_ON() Conversion in input/serio/hp_sdc_mlc.c 



this changes if() BUG(); constructs to BUG_ON() which is
cleaner and can better optimized away

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent 547bc926

drivers/input/serio/hp_sdc_mlc.c

+4 −3
Original line number Diff line number Diff line
@@ -270,9 +270,10 @@ static void hp_sdc_mlc_out (hil_mlc *mlc) { 


 do_control:

	priv->emtestmode = mlc->opacket & HIL_CTRL_TEST;

	if ((mlc->opacket & (HIL_CTRL_APE | HIL_CTRL_IPF)) == HIL_CTRL_APE) {

		BUG(); /* we cannot emulate this, it should not be used. */

	}

	

	/* we cannot emulate this, it should not be used. */

	BUG_ON((mlc->opacket & (HIL_CTRL_APE | HIL_CTRL_IPF)) == HIL_CTRL_APE);

	

	if ((mlc->opacket & HIL_CTRL_ONLY) == HIL_CTRL_ONLY) goto control_only;

	if (mlc->opacket & HIL_CTRL_APE) { 

		BUG(); /* Should not send command/data after engaging APE */