Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcea8030 authored by Tony Breeds's avatar Tony Breeds Committed by Linus Torvalds
Browse files

drivers/video/aty/radeon_base.c: notify user if sysfs_create_bin_file() failed 



Current kernel builds warn about:
drivers/video/aty/radeon_base.c: In function 'radeonfb_pci_register':
drivers/video/aty/radeon_base.c:2334: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result
drivers/video/aty/radeon_base.c:2336: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result

Do minimal checking of these functions and issue a warning if either
fails.  They don't seem to be critical..

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: default avatarTony Breeds <tony@bakeyournoodle.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7951ac91

drivers/video/aty/radeon_base.c

+8 −2
Original line number Diff line number Diff line
@@ -2161,6 +2161,7 @@ static int __devinit radeonfb_pci_register (struct pci_dev *pdev, 
	struct radeonfb_info *rinfo;

	int ret;

	unsigned char c1, c2;

	int err = 0;



	pr_debug("radeonfb_pci_register BEGIN\n");
@@ -2340,9 +2341,14 @@ static int __devinit radeonfb_pci_register (struct pci_dev *pdev, 


	/* Register some sysfs stuff (should be done better) */

	if (rinfo->mon1_EDID)

		sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);

		err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj,

						&edid1_attr);

	if (rinfo->mon2_EDID)

		sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);

		err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj,

						&edid2_attr);

	if (err)

		pr_warning("%s() Creating sysfs files failed, continuing\n",

			   __func__);



	/* save current mode regs before we switch into the new one

	 * so we can restore this upon __exit