Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcd62cf7 authored by Mike Isely's avatar Mike Isely Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (11334): pvrusb2: Fix uninitialized tuner_setup field(s) 



Any time a struct (especially one not defined by this driver) is
allocated, we MUST zero its underlying storage.  This makes our usage
of the struct predictable and robust against future changes where
fields might be added that we don't know about.  Failing to do this
with tuner_setup left the config field uninitialized which then caused
trouble with the tuner type used for HVR-1950 devices.

Signed-off-by: default avatarMike Isely <isely@pobox.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 7bf56f94

drivers/media/video/pvrusb2/pvrusb2-hdw.c

+1 −0
Original line number Diff line number Diff line
@@ -2926,6 +2926,7 @@ static void pvr2_subdev_update(struct pvr2_hdw *hdw) 
		pvr2_trace(PVR2_TRACE_CHIPS, "subdev tuner set_type(%d)",

			   hdw->tuner_type);

		if (((int)(hdw->tuner_type)) >= 0) {

			memset(&setup, 0, sizeof(setup));

			setup.addr = ADDR_UNSET;

			setup.type = hdw->tuner_type;

			setup.mode_mask = T_RADIO | T_ANALOG_TV;