Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcc7c09d authored by Jeff Layton's avatar Jeff Layton Committed by Steve French
Browse files

cifs: fix buffer format byte on NT Rename/hardlink 



Discovered at Connnectathon 2009...

The buffer format byte and the pad are transposed in NT_RENAME calls
(which are used to set hardlinks). Most servers seem to ignore this
fact, but NetApp filers throw back an error due to this problem. This
patch fixes it.

CC: Stable <stable@kernel.org>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 03824577

fs/cifs/cifssmb.c

+4 −2
Original line number Diff line number Diff line
@@ -2377,8 +2377,10 @@ winCreateHardLinkRetry: 
				     PATH_MAX, nls_codepage, remap);

		name_len++;	/* trailing null */

		name_len *= 2;

		pSMB->OldFileName[name_len] = 0;	/* pad */

		pSMB->OldFileName[name_len + 1] = 0x04;



		/* protocol specifies ASCII buffer format (0x04) for unicode */

		pSMB->OldFileName[name_len] = 0x04;

		pSMB->OldFileName[name_len + 1] = 0x00; /* pad */

		name_len2 =

		    cifsConvertToUCS((__le16 *)&pSMB->OldFileName[name_len + 2],

				     toName, PATH_MAX, nls_codepage, remap);