Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcafccbd authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman
Browse files

rndis_wlan: add return value validation 




[ Upstream commit 9dc7efd3978aa67ae598129d2a3f240b390ce508 ]

Function create_singlethread_workqueue() will return a NULL pointer if
there is no enough memory, and its return value should be validated
before using. However, in function rndis_wlan_bind(), its return value
is not checked. This may cause NULL dereference bugs. This patch fixes
it.

Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 868a3686

drivers/net/wireless/rndis_wlan.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -3425,6 +3425,10 @@ static int rndis_wlan_bind(struct usbnet *usbdev, struct usb_interface *intf) 




	/* because rndis_command() sleeps we need to use workqueue */

	/* because rndis_command() sleeps we need to use workqueue */

	priv->workqueue = create_singlethread_workqueue("rndis_wlan");

	priv->workqueue = create_singlethread_workqueue("rndis_wlan");

	if (!priv->workqueue) {

		wiphy_free(wiphy);

		return -ENOMEM;

	}

	INIT_WORK(&priv->work, rndis_wlan_worker);

	INIT_WORK(&priv->work, rndis_wlan_worker);

	INIT_DELAYED_WORK(&priv->dev_poller_work, rndis_device_poller);

	INIT_DELAYED_WORK(&priv->dev_poller_work, rndis_device_poller);

	INIT_DELAYED_WORK(&priv->scan_work, rndis_get_scan_results);

	INIT_DELAYED_WORK(&priv->scan_work, rndis_get_scan_results);