Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc30e76c authored by Jaroslav Kysela's avatar Jaroslav Kysela Committed by Sasha Levin
Browse files

ALSA: hda: controller code - do not export static functions 



commit 37ed398839fa3e0d2de77925097db7a370abb096 upstream.

It is a bad idea to export static functions. GCC for some platforms
shows errors like:

  error: __ksymtab_azx_get_response causes a section type conflict

Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent c78962a5

sound/pci/hda/hda_controller.c

+0 −5
Original line number Diff line number Diff line
@@ -957,7 +957,6 @@ static int azx_alloc_cmd_io(struct azx *chip) 
		dev_err(chip->card->dev, "cannot allocate CORB/RIRB\n");

	return err;

}

EXPORT_SYMBOL_GPL(azx_alloc_cmd_io);



static void azx_init_cmd_io(struct azx *chip)

{
@@ -1022,7 +1021,6 @@ static void azx_init_cmd_io(struct azx *chip) 
	azx_writeb(chip, RIRBCTL, AZX_RBCTL_DMA_EN | AZX_RBCTL_IRQ_EN);

	spin_unlock_irq(&chip->reg_lock);

}

EXPORT_SYMBOL_GPL(azx_init_cmd_io);



static void azx_free_cmd_io(struct azx *chip)

{
@@ -1032,7 +1030,6 @@ static void azx_free_cmd_io(struct azx *chip) 
	azx_writeb(chip, CORBCTL, 0);

	spin_unlock_irq(&chip->reg_lock);

}

EXPORT_SYMBOL_GPL(azx_free_cmd_io);



static unsigned int azx_command_addr(u32 cmd)

{
@@ -1312,7 +1309,6 @@ static int azx_send_cmd(struct hda_bus *bus, unsigned int val) 
	else

		return azx_corb_send_cmd(bus, val);

}

EXPORT_SYMBOL_GPL(azx_send_cmd);



/* get a response */

static unsigned int azx_get_response(struct hda_bus *bus,
@@ -1326,7 +1322,6 @@ static unsigned int azx_get_response(struct hda_bus *bus, 
	else

		return azx_rirb_get_response(bus, addr);

}

EXPORT_SYMBOL_GPL(azx_get_response);



#ifdef CONFIG_SND_HDA_DSP_LOADER

/*