Commit fbd48433 authored Sep 02, 2012 by Wei Yongjun Committed by Helge Deller Feb 20, 2013

parisc: fix possible memory leak in pat_query_module()

pa_pdc_cell has been allocated in this function and so should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Helge Deller <deller@gmx.de>

parent ec758f98

arch/parisc/kernel/inventory.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -186,12 +186,14 @@ pat_query_module(ulong pcell_loc, ulong mod_index)

		if (status != PDC_OK) {
		/* no more cell modules or error */
		kfree(pa_pdc_cell);
		return status;
		}

		temp = pa_pdc_cell->cba;
		dev = alloc_pa_dev(PAT_GET_CBA(temp), &(pa_pdc_cell->mod_path));
		if (!dev) {
		kfree(pa_pdc_cell);
		return PDC_OK;
		}