Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb5ac542 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Linus Torvalds
Browse files

lib: bitmap: make the start index of bitmap_set unsigned 



The compiler can generate slightly smaller and simpler code when it
knows that "start" is non-negative.

Also, use the names "start" and "len" for the two parameters in both
header file and implementation, instead of the previous mix.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 877d9f3b

include/linux/bitmap.h

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ extern int __bitmap_subset(const unsigned long *bitmap1, 
			const unsigned long *bitmap2, unsigned int nbits);

extern int __bitmap_weight(const unsigned long *bitmap, unsigned int nbits);



extern void bitmap_set(unsigned long *map, int i, int len);

extern void bitmap_set(unsigned long *map, unsigned int start, int len);

extern void bitmap_clear(unsigned long *map, int start, int nr);

extern unsigned long bitmap_find_next_zero_area(unsigned long *map,

					 unsigned long size,

lib/bitmap.c

+5 −5
Original line number Diff line number Diff line
@@ -274,21 +274,21 @@ int __bitmap_weight(const unsigned long *bitmap, unsigned int bits) 
}

EXPORT_SYMBOL(__bitmap_weight);



void bitmap_set(unsigned long *map, int start, int nr)

void bitmap_set(unsigned long *map, unsigned int start, int len)

{

	unsigned long *p = map + BIT_WORD(start);

	const int size = start + nr;

	const unsigned int size = start + len;

	int bits_to_set = BITS_PER_LONG - (start % BITS_PER_LONG);

	unsigned long mask_to_set = BITMAP_FIRST_WORD_MASK(start);



	while (nr - bits_to_set >= 0) {

	while (len - bits_to_set >= 0) {

		*p |= mask_to_set;

		nr -= bits_to_set;

		len -= bits_to_set;

		bits_to_set = BITS_PER_LONG;

		mask_to_set = ~0UL;

		p++;

	}

	if (nr) {

	if (len) {

		mask_to_set &= BITMAP_LAST_WORD_MASK(size);

		*p |= mask_to_set;

	}