Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb3ec7ba authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Marc Kleine-Budde
Browse files

can: xilinx_can: fix comparison of unsigned variable 



The variable err was of the type u32. It was being compared with < 0, and being
an unsigned variable the comparison would have been always false.

Moreover, err was getting the return value from set_reset_mode() and
xcan_set_bittiming(), and both are returning int.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 4e2061b1

drivers/net/can/xilinx_can.c

+2 −1
Original line number Diff line number Diff line
@@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev) 
static int xcan_chip_start(struct net_device *ndev)

{

	struct xcan_priv *priv = netdev_priv(ndev);

	u32 err, reg_msr, reg_sr_mask;

	u32 reg_msr, reg_sr_mask;

	int err;

	unsigned long timeout;



	/* Check if it is in reset mode */