Commit fafbfb10 authored Jun 14, 2018 by Zhouyang Jia Committed by Greg Kroah-Hartman Oct 13, 2018

HID: hid-ntrig: add error handling for sysfs_create_group



[ Upstream commit 44d4d51de9a3534a2b63d69efda02a10e66541e4 ]

When sysfs_create_group fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling sysfs_create_group.

Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d02f9650

drivers/hid/hid-ntrig.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -953,6 +953,8 @@ static int ntrig_probe(struct hid_device hdev, const struct hid_device_id id)

	ret = sysfs_create_group(&hdev->dev.kobj,		ret = sysfs_create_group(&hdev->dev.kobj,
	&ntrig_attribute_group);		&ntrig_attribute_group);
			if (ret)
			hid_err(hdev, "cannot create sysfs group\n");

	return 0;		return 0;
	err_free:		err_free: