Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fae8563b authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Only use TX push if a single descriptor is to be written 



Using TX push when notifying the NIC of multiple new descriptors in
the ring will very occasionally cause the TX DMA engine to re-use an
old descriptor.  This can result in a duplicated or partly duplicated
packet (new headers with old data), or an IOMMU page fault.  This does
not happen when the pushed descriptor is the only one written.

TX push also provides little latency benefit when a packet requires
more than one descriptor.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent c73e787a

drivers/net/ethernet/sfc/nic.c

+2 −1
Original line number Diff line number Diff line
@@ -376,7 +376,8 @@ efx_may_push_tx_desc(struct efx_tx_queue *tx_queue, unsigned int write_count) 
		return false;



	tx_queue->empty_read_count = 0;

	return ((empty_read_count ^ write_count) & ~EFX_EMPTY_COUNT_VALID) == 0;

	return ((empty_read_count ^ write_count) & ~EFX_EMPTY_COUNT_VALID) == 0

		&& tx_queue->write_count - write_count == 1;

}



/* For each entry inserted into the software descriptor ring, create a