Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa027c2a authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Linus Torvalds
Browse files

[PATCH] mark struct file_operations const 4



Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

[akpm@sdl.org: dvb fix]
Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2b8693c0
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -885,7 +885,7 @@ out:
	return ret;
}

static struct file_operations adb_fops = {
static const struct file_operations adb_fops = {
	.owner		= THIS_MODULE,
	.llseek		= no_llseek,
	.read		= adb_read,
+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ anslcd_open( struct inode * inode, struct file * file )
	return 0;
}

struct file_operations anslcd_fops = {
const struct file_operations anslcd_fops = {
	.write	= anslcd_write,
	.ioctl	= anslcd_ioctl,
	.open	= anslcd_open,
+1 −1
Original line number Diff line number Diff line
@@ -501,7 +501,7 @@ static int apm_emu_get_info(char *buf, char **start, off_t fpos, int length)
	return p - buf;
}

static struct file_operations apm_bios_fops = {
static const struct file_operations apm_bios_fops = {
	.owner		= THIS_MODULE,
	.read		= do_read,
	.poll		= do_poll,
+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static int nvram_ioctl(struct inode *inode, struct file *file,
	return 0;
}

struct file_operations nvram_fops = {
const struct file_operations nvram_fops = {
	.owner		= THIS_MODULE,
	.llseek		= nvram_llseek,
	.read		= read_nvram,
+1 −1
Original line number Diff line number Diff line
@@ -1277,7 +1277,7 @@ static int smu_release(struct inode *inode, struct file *file)
}


static struct file_operations smu_device_fops = {
static const struct file_operations smu_device_fops = {
	.llseek		= no_llseek,
	.read		= smu_read,
	.write		= smu_write,
Loading