Commit f99ebf0a authored Jan 06, 2009 by Rakib Mullick Committed by Linus Torvalds Jan 06, 2009

init: properly placing noinline keyword



checkpatch warns about 'static void noinline'.  It wants `static noinline
void'.

Both are permissible, but the kernel consistently uses `static inline' and
`static noinline', and consistency is good.  Hence let's keep the
checkpatch warning and fix up this code site.

[akpm@linux-foundation.org: rewrote changelog]
Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 91f47662

init/main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -447,7 +447,7 @@ static void __init setup_command_line(char *command_line)
		* gcc-3.4 accidentally inlines this function, so use noinline.
		*/

		static void noinline __init_refok rest_init(void)
		static noinline void __init_refok rest_init(void)
		__releases(kernel_lock)
		{
		int pid;
		@@ -786,7 +786,7 @@ static void run_init_process(char *init_filename)
		/* This is a non __init function. Force it to be noinline otherwise gcc
		* makes it inline to init() and it becomes part of init.text section
		*/
		static int noinline init_post(void)
		static noinline int init_post(void)
		{
		free_initmem();
		unlock_kernel();