Commit f9525833 authored Jan 28, 2015 by Jan Kara Committed by Greg Kroah-Hartman Feb 05, 2015

udf: Release preallocation on last writeable close



commit b07ef35244424cbeda9844198607c7077099c82c upstream.

Commit 6fb1ca92 "udf: Fix race between write(2) and close(2)"
changed the condition when preallocation is released. The idea was that
we don't want to release the preallocation for an inode on close when
there are other writeable file descriptors for the inode. However the
condition was written in the opposite way so we released preallocation
only if there were other writeable file descriptors. Fix the problem by
changing the condition properly.

Fixes: 6fb1ca92
Reported-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 75229a26

fs/udf/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -224,7 +224,7 @@ out:
		static int udf_release_file(struct inode inode, struct file filp)
		{
		if (filp->f_mode & FMODE_WRITE &&
		atomic_read(&inode->i_writecount) > 1) {
		atomic_read(&inode->i_writecount) == 1) {
		/*
		* Grab i_mutex to avoid races with writes changing i_size
		* while we are running.