Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f885fb73 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Christoph Hellwig
Browse files

drivers: scsi: storvsc: Set srb_flags in all cases 



Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the
Windows host require this. The host validates the command and SRB flags
prior to passing the command down to native driver stack.

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 56b26e69

drivers/scsi/storvsc_drv.c

+5 −7
Original line number Diff line number Diff line
@@ -1601,26 +1601,24 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) 
	vm_srb = &cmd_request->vstor_packet.vm_srb;

	vm_srb->win8_extension.time_out_value = 60;



	vm_srb->win8_extension.srb_flags |=

		(SRB_FLAGS_QUEUE_ACTION_ENABLE |

		SRB_FLAGS_DISABLE_SYNCH_TRANSFER);



	/* Build the SRB */

	switch (scmnd->sc_data_direction) {

	case DMA_TO_DEVICE:

		vm_srb->data_in = WRITE_TYPE;

		vm_srb->win8_extension.srb_flags |= SRB_FLAGS_DATA_OUT;

		vm_srb->win8_extension.srb_flags |=

			(SRB_FLAGS_QUEUE_ACTION_ENABLE |

			SRB_FLAGS_DISABLE_SYNCH_TRANSFER);

		break;

	case DMA_FROM_DEVICE:

		vm_srb->data_in = READ_TYPE;

		vm_srb->win8_extension.srb_flags |= SRB_FLAGS_DATA_IN;

		vm_srb->win8_extension.srb_flags |=

			(SRB_FLAGS_QUEUE_ACTION_ENABLE |

			SRB_FLAGS_DISABLE_SYNCH_TRANSFER);

		break;

	default:

		vm_srb->data_in = UNKNOWN_TYPE;

		vm_srb->win8_extension.srb_flags = 0;

		vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN |

						     SRB_FLAGS_DATA_OUT);

		break;

	}