Commit f7b2bb85 authored Oct 28, 2011 by Dan Carpenter Committed by Takashi Iwai Oct 31, 2011

ALSA: hwdep: silence integer overflow warning



Smatch complains that if device is INT_MAX then device + 1 can
overflow.  It just means we would have an annoying loop while we
check all the devices from -2147483648 to SNDRV_MINOR_HWDEPS.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 8128c9f2

sound/core/hwdep.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -272,7 +272,14 @@ static int snd_hwdep_control_ioctl(struct snd_card *card,
		if (get_user(device, (int __user *)arg))
		return -EFAULT;
		mutex_lock(&register_mutex);
		device = device < 0 ? 0 : device + 1;

		if (device < 0)
		device = 0;
		else if (device < SNDRV_MINOR_HWDEPS)
		device++;
		else
		device = SNDRV_MINOR_HWDEPS;

		while (device < SNDRV_MINOR_HWDEPS) {
		if (snd_hwdep_search(card, device))
		break;