Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f78729b4 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: drivers/media/dvb/siano: Remove double test 

The same expression is tested twice and the result is the same each time.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6b81bef8

drivers/media/dvb/siano/smscoreapi.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -1504,8 +1504,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum, 
		u32 msgData[3]; /* keep it 3 ! */

		u32 msgData[3]; /* keep it 3 ! */

	} *pMsg;

	} *pMsg;





	if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) ||

	if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER))

			(PinNum > MAX_GPIO_PIN_NUMBER))

		return -EINVAL;

		return -EINVAL;





	totalLen = sizeof(struct SmsMsgHdr_ST) +

	totalLen = sizeof(struct SmsMsgHdr_ST) +