Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7414531 authored by Mitch Williams's avatar Mitch Williams Committed by Jeff Kirsher
Browse files

i40e: acknowledge VFLR when disabling SR-IOV 



When SR-IOV is disabled, the (now nonexistent) virtual function
devices undergo a VFLR event. We don't need to handle this event
because the VFs are gone, but we do need to tell the HW that they are
complete. This fixes an issue with a phantom VFLR and broken VFs when
SR-IOV is re-enabled.

Change-Id: I7580b49ded0158172a85b14661ec212af77000c8
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 3197ce22

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+13 −2
Original line number Diff line number Diff line
@@ -726,7 +726,9 @@ static bool i40e_vfs_are_assigned(struct i40e_pf *pf) 
 **/

void i40e_free_vfs(struct i40e_pf *pf)

{

	int i, tmp;

	struct i40e_hw *hw = &pf->hw;

	u32 reg_idx, bit_idx;

	int i, tmp, vf_id;



	if (!pf->vf)

		return;
@@ -748,8 +750,17 @@ void i40e_free_vfs(struct i40e_pf *pf) 
	kfree(pf->vf);

	pf->vf = NULL;



	if (!i40e_vfs_are_assigned(pf))

	if (!i40e_vfs_are_assigned(pf)) {

		pci_disable_sriov(pf->pdev);

		/* Acknowledge VFLR for all VFS. Without this, VFs will fail to

		 * work correctly when SR-IOV gets re-enabled.

		 */

		for (vf_id = 0; vf_id < tmp; vf_id++) {

			reg_idx = (hw->func_caps.vf_base_id + vf_id) / 32;

			bit_idx = (hw->func_caps.vf_base_id + vf_id) % 32;

			wr32(hw, I40E_GLGEN_VFLRSTAT(reg_idx), (1 << bit_idx));

		}

	}

	else

		dev_warn(&pf->pdev->dev,

			 "unable to disable SR-IOV because VFs are assigned.\n");