Commit f702a6ef authored Nov 04, 2015 by Markus Elfring Committed by Nikhilesh Reddy Feb 11, 2016

UBIFS: Delete unnecessary checks before the function call "iput"



The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

CRs-Fixed: 975289
Change-Id: I46adad6d364bed3ab053974cfe71a568d548307f
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
Git-commit: 54bcfdf19ec7c2f2788fa76426c91abdc4dab973
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: Nikhilesh Reddy <reddyn@codeaurora.org>

parent baf2b5fa

fs/ubifs/recovery.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1331,7 +1331,6 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
		struct size_entry e, n;

		rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
		if (e->inode)
		iput(e->inode);
		kfree(e);
		}
		@@ -1533,7 +1532,6 @@ int ubifs_recover_size(struct ubifs_info *c)
		err = fix_size_in_place(c, e);
		if (err)
		return err;
		if (e->inode)
		iput(e->inode);
		}
		}