Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6e984e6 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Tejun Heo
Browse files

ipr: qc_fill_rtf() method should not store alternate status register 



The 'ctl' field of  the 'struct ata_taskfile' is not really dual purpose, i.e.
it is not intended  for storing the alternate status register (which is mapped
at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
not do this as well...

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 1b20f6a9

drivers/scsi/ipr.c

+0 −1
Original line number Diff line number Diff line
@@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_queued_cmd *qc) 
	tf->hob_lbal = g->hob_lbal;

	tf->hob_lbam = g->hob_lbam;

	tf->hob_lbah = g->hob_lbah;

	tf->ctl = g->alt_status;



	return true;

}