Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6c1c8ff authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI/ACPI: Check acpi_resource_to_address64() return value 



We should check the acpi_resource_to_address64() return value, which
also removes the need to validate the resource type beforehand.
No functional change.

Found by Coverity (CID 113815).

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 12b03188

drivers/acpi/pci_root.c

+3 −4
Original line number Diff line number Diff line
@@ -100,13 +100,12 @@ get_root_bridge_busnr_callback(struct acpi_resource *resource, void *data) 
{

	struct resource *res = data;

	struct acpi_resource_address64 address;

	acpi_status status;



	if (resource->type != ACPI_RESOURCE_TYPE_ADDRESS16 &&

	    resource->type != ACPI_RESOURCE_TYPE_ADDRESS32 &&

	    resource->type != ACPI_RESOURCE_TYPE_ADDRESS64)

	status = acpi_resource_to_address64(resource, &address);

	if (ACPI_FAILURE(status))

		return AE_OK;



	acpi_resource_to_address64(resource, &address);

	if ((address.address_length > 0) &&

	    (address.resource_type == ACPI_BUS_NUMBER_RANGE)) {

		res->start = address.minimum;