Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f674e72f authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net/key/af_key.c: add range checks on ->sadb_x_policy_len 



Because sizeof() is size_t then if "len" is negative, it counts as a
large positive value.

The call tree looks like:
pfkey_sendmsg()
-> pfkey_process()
   -> pfkey_spdadd()
      -> parse_ipsecrequests()

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 862096a8

net/key/af_key.c

+3 −0
Original line number Diff line number Diff line
@@ -1923,6 +1923,9 @@ parse_ipsecrequests(struct xfrm_policy *xp, struct sadb_x_policy *pol) 
	int len = pol->sadb_x_policy_len*8 - sizeof(struct sadb_x_policy);

	struct sadb_x_ipsecrequest *rq = (void*)(pol+1);



	if (pol->sadb_x_policy_len * 8 < sizeof(struct sadb_x_policy))

		return -EINVAL;



	while (len >= sizeof(struct sadb_x_ipsecrequest)) {

		if ((err = parse_ipsecrequest(xp, rq)) < 0)

			return err;