Commit f5a6d958 authored Aug 09, 2008 by Rafael J. Wysocki Committed by Greg Kroah-Hartman Aug 21, 2008

PM: Remove WARN_ON from device_pm_add



PM: Remove WARN_ON from device_pm_add

Fix message in device_pm_add() saying that the device will not be
added to dpm_list, although in fact the device is going to be added
to the list regardless of the ordering violation.

Remove the WARN_ON(true) triggered in that situation, because it is
hit by USB very often and spams the users' logs.

This patch fixes bug #11263

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent c906a48a

drivers/base/power/main.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -74,11 +74,9 @@ void device_pm_add(struct device *dev)
		kobject_name(&dev->kobj));
		mutex_lock(&dpm_list_mtx);
		if (dev->parent) {
		if (dev->parent->power.status >= DPM_SUSPENDING) {
		dev_warn(dev, "parent %s is sleeping, will not add\n",
		if (dev->parent->power.status >= DPM_SUSPENDING)
		dev_warn(dev, "parent %s should not be sleeping\n",
		dev->parent->bus_id);
		WARN_ON(true);
		}
		} else if (transition_started) {
		/*
		* We refuse to register parentless devices while a PM