Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4e95b33 authored by Zheng Liu's avatar Zheng Liu Committed by Theodore Ts'o
Browse files

ext4: honor O_(D)SYNC semantic in ext4_fallocate() 

Ext4 must make sure the transaction to be commited to the disk when
user opens a file with O_(D)SYNC flag and do a fallocate(2) call.

This problem had been reported by Christoph Hellwig in this thread:
http://www.spinics.net/lists/linux-btrfs/msg13621.html



Reported-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 1c8457ca

fs/ext4/extents.c

+2 −0
Original line number Diff line number Diff line
@@ -4420,6 +4420,8 @@ retry: 
		ext4_falloc_update_inode(inode, mode, new_size,

					 (map.m_flags & EXT4_MAP_NEW));

		ext4_mark_inode_dirty(handle, inode);

		if ((file->f_flags & O_SYNC) && ret >= max_blocks)

			ext4_handle_sync(handle);

		ret2 = ext4_journal_stop(handle);

		if (ret2)

			break;