Commit f4a3fc03 authored Oct 28, 2010 by Andy Grover Committed by David S. Miller Oct 30, 2010

RDS: Clean up error handling in rds_cmsg_rdma_args



We don't need to set ret = 0 at the end -- it's initialized to 0.

Also, don't increment s_send_rdma stat if we're exiting with an
error.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a09f69c4

net/rds/rdma.c

+2 −3

Original line number	Original line	Diff line number	Diff line
	@@ -664,12 +664,11 @@ int rds_cmsg_rdma_args(struct rds_sock rs, struct rds_message rm,
	}		}
	op->op_bytes = nr_bytes;		op->op_bytes = nr_bytes;

	ret = 0;
	out:		out:
	kfree(pages);		kfree(pages);
	if (ret)		if (ret)
	rds_rdma_free_op(op);		rds_rdma_free_op(op);
			else
	rds_stats_inc(s_send_rdma);		rds_stats_inc(s_send_rdma);

	return ret;		return ret;