Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f45934e0 authored by Fubo Chen's avatar Fubo Chen Committed by James Bottomley
Browse files

[SCSI] tcm_mod_builder.py: Fix generated *_drop_nodeacl() handler 



This patch adds the missing core_tpg_del_initiator_node_acl() call required
by fabric modules for struct se_node_acl->acl_group context shutdown via

	target_core_fabric_configfs.c:target_fabric_nacl_base_release() ->

		struct target_core_fabric_ops->fabric_drop_nodeacl()

for tcm_mod_builder.py generated $FABRIC_MOD_configfs.c skeleton code.

Signed-off-by: default avatarFubo Chen <fubo.chen@gmail.com>
Signed-off-by: default avatarNicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 12a18bdc

Documentation/target/tcm_mod_builder.py

+1 −0
Original line number Original line Diff line number Diff line
@@ -289,6 +289,7 @@ def tcm_mod_build_configfs(proto_ident, fabric_mod_dir_var, fabric_mod_name): 
	buf += "{\n"

	buf += "{\n"

	buf += "	struct " + fabric_mod_name + "_nacl *nacl = container_of(se_acl,\n"

	buf += "	struct " + fabric_mod_name + "_nacl *nacl = container_of(se_acl,\n"

	buf += "				struct " + fabric_mod_name + "_nacl, se_node_acl);\n"

	buf += "				struct " + fabric_mod_name + "_nacl, se_node_acl);\n"

	buf += "	core_tpg_del_initiator_node_acl(se_acl->se_tpg, se_acl, 1);\n"

	buf += "	kfree(nacl);\n"

	buf += "	kfree(nacl);\n"

	buf += "}\n\n"

	buf += "}\n\n"