Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4498359 authored by Kasin Li's avatar Kasin Li Committed by Greg Kroah-Hartman
Browse files

drm/msm: Fix potential buffer overflow issue 



commit 4a630fadbb29d9efaedb525f1a8f7449ad107641 upstream.

In function submit_create, if nr_cmds or nr_bos is assigned with
negative value, the allocated buffer may be small than intended.
Using this buffer will lead to buffer overflow issue.

Signed-off-by: default avatarKasin Li <donglil@codeaurora.org>
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 163e8355

drivers/gpu/drm/msm/msm_gem_submit.c

+5 −2
Original line number Diff line number Diff line
@@ -34,10 +34,13 @@ static inline void __user *to_user_ptr(u64 address) 
}



static struct msm_gem_submit *submit_create(struct drm_device *dev,

		struct msm_gpu *gpu, int nr)

		struct msm_gpu *gpu, uint32_t nr)

{

	struct msm_gem_submit *submit;

	int sz = sizeof(*submit) + (nr * sizeof(submit->bos[0]));

	uint64_t sz = sizeof(*submit) + (nr * sizeof(submit->bos[0]));



	if (sz > SIZE_MAX)

		return NULL;



	submit = kmalloc(sz, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);

	if (submit) {