Commit f42178c0 authored Jul 12, 2018 by Tony Battersby Committed by Greg Kroah-Hartman Aug 09, 2018

scsi: sg: fix minor memory leak in error path



commit c170e5a8d222537e98aa8d4fddb667ff7a2ee114 upstream.

Fix a minor memory leak when there is an error opening a /dev/sg device.

Fixes: cc833acb ("sg: O_EXCL and other lock handling")
Cc: <stable@vger.kernel.org>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fc7ec0c4

drivers/scsi/sg.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2242,6 +2242,7 @@ sg_add_sfp(Sg_device * sdp)
		write_lock_irqsave(&sdp->sfd_lock, iflags);
		if (atomic_read(&sdp->detaching)) {
		write_unlock_irqrestore(&sdp->sfd_lock, iflags);
		kfree(sfp);
		return ERR_PTR(-ENODEV);
		}
		list_add_tail(&sfp->sfd_siblings, &sdp->sfds);