Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3ef11b4 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: wm831x-ldo: Fix max_uV for gp_ldo and aldo linear range settings 



Fix the linear range settings in commit 5ff26a14
"regulator: wm831x-ldo: Convert to use linear ranges".

For wm831x_gp_ldo:
We have below equations for list voltage before converting to linear ranges:

sel <= 0xe:
        volt = 0.9-1.6V in 50mV steps
sel <= 0x1f:
        volt = 1.7-3.3V in 100mV steps

max_uV for the first linear range should be 1600000 rather than 1650000. Fix it.

For wm831x_aldo:
We have below equations for list voltage before converting to linear ranges:

sel <= 0xc:
        volt = 1-1.6V in 50mV steps
sel <= 0x1f
        volt = 1.7-3.5V in 100mV steps

max_uV for the first linear range should be 1600000 rather than 1650000. Fix it.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 272b98c6

drivers/regulator/wm831x-ldo.c

+2 −2
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ static irqreturn_t wm831x_ldo_uv_irq(int irq, void *data) 
 */



static const struct regulator_linear_range wm831x_gp_ldo_ranges[] = {

	{ .min_uV =  900000, .max_uV = 1650000, .min_sel =  0, .max_sel = 14,

	{ .min_uV =  900000, .max_uV = 1600000, .min_sel =  0, .max_sel = 14,

	  .uV_step =  50000 },

	{ .min_uV = 1700000, .max_uV = 3300000, .min_sel = 15, .max_sel = 31,

	  .uV_step = 100000 },
@@ -332,7 +332,7 @@ static struct platform_driver wm831x_gp_ldo_driver = { 
 */



static const struct regulator_linear_range wm831x_aldo_ranges[] = {

	{ .min_uV = 1000000, .max_uV = 1650000, .min_sel =  0, .max_sel = 12,

	{ .min_uV = 1000000, .max_uV = 1600000, .min_sel =  0, .max_sel = 12,

	  .uV_step =  50000 },

	{ .min_uV = 1700000, .max_uV = 3500000, .min_sel = 13, .max_sel = 31,

	  .uV_step = 100000 },