Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f375fc52 authored by Daniel Mack's avatar Daniel Mack Committed by Greg Kroah-Hartman
Browse files

usb: ehci-mxc: check for pdata before dereferencing 



Commit 7e8d5cd9 ("USB: Add EHCI support for MX27 and MX31 based
boards") introduced code that could potentially lead to a NULL pointer
dereference on driver removal.

Fix this by checking for the value of pdata before dereferencing it.

Signed-off-by: default avatarDaniel Mack <zonque@gmail.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org> # 2.6.33+
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67e51ec4

drivers/usb/host/ehci-mxc.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -184,7 +184,7 @@ static int ehci_mxc_drv_remove(struct platform_device *pdev) 
	if (pdata && pdata->exit)

	if (pdata && pdata->exit)

		pdata->exit(pdev);

		pdata->exit(pdev);





	if (pdata->otg)

	if (pdata && pdata->otg)

		usb_phy_shutdown(pdata->otg);

		usb_phy_shutdown(pdata->otg);





	clk_disable_unprepare(priv->usbclk);

	clk_disable_unprepare(priv->usbclk);