Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f32b6c63 authored by Eric Holmberg's avatar Eric Holmberg Committed by Matt Wagantall
Browse files

soc: qcom: glink: add error logging for glink_tx failures 



One failure path in glink_tx() does not log a failure message and the
loopback server does not log the return code which causes ambiguity when
triaging logs.

Add logging of missing error path and the return code.

Change-Id: I2ef27c4d71f00c19600b2e2f53f1655f87bbfb18
Signed-off-by: default avatarEric Holmberg <eholmber@codeaurora.org>
parent 499b453a

drivers/soc/qcom/glink.c

+5 −1
Original line number Diff line number Diff line
@@ -2222,8 +2222,12 @@ static int glink_tx_common(void *handle, void *pkt_priv, 
			reinit_completion(&ctx->int_req_complete);

			ret = ctx->transport_ptr->ops->tx_cmd_rx_intent_req(

				ctx->transport_ptr->ops, ctx->lcid, size);

			if (ret)

			if (ret) {

				GLINK_ERR_CH(ctx,

					"%s: Request intent failed %d\n",

					__func__, ret);

				return ret;

			}



			/* wait for the remote intent req ack */

			wait_for_completion(&ctx->int_req_ack_complete);

drivers/soc/qcom/glink_loopback_server.c

+2 −2
Original line number Diff line number Diff line
@@ -1184,10 +1184,10 @@ static void glink_lbsrv_tx_worker(struct work_struct *work) 
				flags);

		mutex_unlock(&tmp_ch_info->ch_info_lock);

		if (ret < 0 && ret != -EAGAIN) {

			LBSRV_ERR("%s:%s:%s %s: Error tx'ing data...\n",

			LBSRV_ERR("%s:%s:%s %s: TX Error %d\n",

					tmp_ch_info->transport,

					tmp_ch_info->edge,

					tmp_ch_info->name, __func__);

					tmp_ch_info->name, __func__, ret);

			glink_lbsrv_free_data(tmp_work_info->data,

					      tmp_work_info->buf_type);

			kfree(tmp_work_info);